added logic to fix map reset #1969
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrAcula27
requested changes
May 28, 2025
There was a problem hiding this comment.
@DorianDeptuch, thanks for taking on this issue!
I think the change works as intended; however, can you add a brief description to the PR of what reviewers need to test for so we know if the code change worked?
- If I understood the issue, DEV - Bugfix: Outside click reset is being applied even when user has not selected an NC #1919, correctly, when no NC is selected & the user clicks outside any NC boundary (regardless of zoom level), nothing should happen; this is the behavior I am experiencing.
- Secondly, can you add, both in the original issue DEV - Bugfix: Outside click reset is being applied even when user has not selected an NC #1919 (for the product team) and in the PR (for us), a before and an after screenshot/video of the bug and the fix?
Thanks!
|
@DrAcula27, thank you for pointing those out, I have added before and after screen recordings to both the PR and the original issue. I have also added testing instructions to clarify what the intended outcome is meant to be. Please let me know if there are any additional changes that I can make! |
DrAcula27
approved these changes
May 29, 2025
There was a problem hiding this comment.
@DorianDeptuch Thanks for updating this! Your code passed the ABC's, including:
- PR is made from the correct branch
- PR links to the correct issue:
- The correct file
components/Map/Map.jsxwas edited - No extra edits were made
- Appearance of the website is unchanged (Chrome and Firefox)
- Can confirm the expected behavior on my end as well (Chrome and Firefox)
Approved! 👍
|
ETA for review, Friday 2025-06-09 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1919
mainbranchAny questions? See the getting started guide
Screen recording before fix
Screen.Recording.2025-05-28.at.5.19.25.PM.mov
Screen recording after fix
Screen.Recording.2025-05-28.at.5.19.49.PM.mov
Testing Instructions:
1.) The outside click reset should only trigger when an NC is selected
2.) Clicking outside without any NC selected should not cause the camera to zoom out
3.) Without Selecting an NC:
Load the map page
Click outside any NC boundaries
Observe that no camera reset or unintended behavior occurs
4.) After Selecting an NC:
Click on a specific NC to select it
Click outside the NC boundaries
Verify that the camera zooms out to the starting position