Skip to content

added logic to fix map reset #1969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DorianDeptuch
Copy link
Member

@DorianDeptuch DorianDeptuch commented May 21, 2025

Fixes #1919

  • Up to date with main branch
  • Branch name follows guidelines
  • All PR Status checks are successful
  • Peer reviewed and approved

Any questions? See the getting started guide

Screen recording before fix
Screen.Recording.2025-05-28.at.5.19.25.PM.mov
Screen recording after fix
Screen.Recording.2025-05-28.at.5.19.49.PM.mov

Testing Instructions:

1.) The outside click reset should only trigger when an NC is selected
2.) Clicking outside without any NC selected should not cause the camera to zoom out

3.) Without Selecting an NC:

  • Load the map page

  • Click outside any NC boundaries

  • Observe that no camera reset or unintended behavior occurs

4.) After Selecting an NC:

  • Click on a specific NC to select it

  • Click outside the NC boundaries

  • Verify that the camera zooms out to the starting position

@DrAcula27 DrAcula27 self-requested a review May 28, 2025 22:20
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DorianDeptuch, thanks for taking on this issue!
I think the change works as intended; however, can you add a brief description to the PR of what reviewers need to test for so we know if the code change worked?

Thanks!

@DorianDeptuch
Copy link
Member Author

@DrAcula27, thank you for pointing those out, I have added before and after screen recordings to both the PR and the original issue. I have also added testing instructions to clarify what the intended outcome is meant to be. Please let me know if there are any additional changes that I can make!

@DorianDeptuch DorianDeptuch requested a review from DrAcula27 May 29, 2025 01:06
Copy link
Member

@DrAcula27 DrAcula27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DorianDeptuch Thanks for updating this! Your code passed the ABC's, including:

@DorianDeptuch DorianDeptuch requested a review from DrAcula27 June 4, 2025 05:13
@ryanfchase ryanfchase self-requested a review June 4, 2025 19:31
@ryanfchase
Copy link
Member

ETA for review, Friday 2025-06-09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEV - Bugfix: Outside click reset is being applied even when user has not selected an NC
3 participants